Two tzcode fixes

Olson, Arthur David (NIH/NCI) [E] olsona at dc37a.nci.nih.gov
Tue Dec 5 14:37:51 UTC 2006


> diff --git a/timezone/zic.c b/timezone/zic.c index 57dc531..4e3f42f
100644
> --- a/timezone/zic.c
> +++ b/timezone/zic.c
> @@ -650,7 +650,7 @@ const char * const	tofile;
>  						"../");
>  					symlinkcontents =
>
ecatalloc(symlinkcontents,
> -						fromfile);
> +							  fromname);
>  					result =
symlink(symlinkcontents,
>  						toname);
> 					if (result == 0)

I don't believe so. "fromname" is the time zone name that appears in the
input files;
"fromfile" is this name with the name of the directory where output is
supposed to go prepended.
Using "fromname" above would yield the moral equivalent of
"/America/New_York" as a symbolic link, which is not what we want.

> diff --git a/timezone/zdump.c b/timezone/zdump.c index
45ce641..d525da1 100644
> --- a/timezone/zdump.c
> +++ b/timezone/zdump.c
> @@ -389,7 +389,7 @@ _("%s: usage is %s [ --version ] [ -v ]
>  	}
>  	if (fflush(stdout) || ferror(stdout)) {
>  		(void) fprintf(stderr, "%s: ", progname);
> -		(void) perror(_("Error writing standard output"));
> +		(void) perror(_("Error writing to standard output"));
>  		exit(EXIT_FAILURE);
>  	}
>  	exit(EXIT_SUCCESS);

I'll go ahead and buy this change (if only to make the lives of GNU
folks easier).




More information about the tz mailing list