[tz] dead code in zic

Christos Zoulas christos at zoulas.com
Wed Mar 6 01:01:17 UTC 2013


On LP32 machines, the following code is dead:

dayoff is long 
min_time is zic_t -> int_fast64_t

        if (dayoff < min_time / SECSPERDAY) {
                error(_("time too small"));
                return;
        }               
        if (dayoff > max_time / SECSPERDAY) {   
                error(_("time too large"));
                return; 
        }                       

The vax gcc-4.1 detects this; later versions of gcc don't. But all of them
will warn, if you change min_time and max_time from const zic_t to #define's.

What's the correct fix here?

http://releng.netbsd.org/builds/HEAD/201303041020Z/vax.build.failed

christos


More information about the tz mailing list