[tz] dead code in zic

Christos Zoulas christos at zoulas.com
Wed Mar 6 03:11:54 UTC 2013

On Mar 5, 10:05pm, arthurdavidolson at gmail.com (Arthur David Olson) wrote:
-- Subject: Re: [tz] dead code in zic

| While the code in question can surely be improved, it wasn't/isn't a no-op
| on systems where both time_t's and long's were/are 32-bit entities.

It might not have been when zic_t was a time_t (if it ever was), but it is
a no-op now because zic_t is int_fast64_t. If time_t is 32 or 64 is not
relevant to the particular comparison.

| The code in question dates back to when "long" was the longest integer type
| available with all compilers ("long long" was not universal then).

Yes, but things have changed and the code can be made more portable and
work better across a wider set of platforms.


More information about the tz mailing list