[tz] Troll and zic warnings

Arthur David Olson arthurdavidolson at gmail.com
Tue Mar 25 14:36:08 UTC 2014


It may be useful to have zic warn when producing a binary with more than
1200 transition times; one possibility is attached (and appears below with
tabs mangled).

To make room for the new code, a warning about pre-1998 versions of zic has
been removed.-)

    @dashdashado

*** tz2014braw/zic.c    2014-03-20 23:21:43.000000000 -0400
--- tz2014bcooked/zic.c    2014-03-25 10:19:28.470390300 -0400
***************
*** 962,969 ****
          error(_("time overflow"));
          return 0;
      }
-     if (noise && hh == HOURSPERDAY && mm == 0 && ss == 0)
-         warning(_("24:00 not handled by pre-1998 versions of zic"));
      if (noise && (hh > HOURSPERDAY ||
          (hh == HOURSPERDAY && (mm != 0 || ss != 0))))
  warning(_("values over 24 hours not handled by pre-2007 versions of
zic"));
--- 962,967 ----
***************
*** 1503,1508 ****
--- 1501,1508 ----
          }
          timecnt = toi;
      }
+     if (noise && timecnt > 1200)
+         warning(_("pre-2014 clients may mishandle more than 1200
transition times"));
      /*
      ** Transfer.
      */
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mm.icann.org/pipermail/tz/attachments/20140325/a4793cb0/attachment.html>
-------------- next part --------------
*** tz2014braw/zic.c	2014-03-20 23:21:43.000000000 -0400
--- tz2014bcooked/zic.c	2014-03-25 10:19:28.470390300 -0400
***************
*** 962,969 ****
  		error(_("time overflow"));
  		return 0;
  	}
- 	if (noise && hh == HOURSPERDAY && mm == 0 && ss == 0)
- 		warning(_("24:00 not handled by pre-1998 versions of zic"));
  	if (noise && (hh > HOURSPERDAY ||
  		(hh == HOURSPERDAY && (mm != 0 || ss != 0))))
  warning(_("values over 24 hours not handled by pre-2007 versions of zic"));
--- 962,967 ----
***************
*** 1503,1508 ****
--- 1501,1508 ----
  		}
  		timecnt = toi;
  	}
+ 	if (noise && timecnt > 1200)
+ 		warning(_("pre-2014 clients may mishandle more than 1200 transition times"));
  	/*
  	** Transfer.
  	*/


More information about the tz mailing list