[tz] [C/C++ PATCH] Implement -Wshift-negative-value (PR c/65179)

Christos Zoulas christos at zoulas.com
Tue May 12 11:53:31 UTC 2015


On May 11,  3:18pm, sellcey at imgtec.com (Steve Ellcey) wrote:
-- Subject: Re: [tz] [C/C++ PATCH] Implement -Wshift-negative-value (PR c/651

| FYI: I put this into my glibc sources (the private.h, zdump.c, and zic.c
| parts, glibc doesn't have localtime.c in the timezone directory and the
| one in the time directory doesn't look like it matches what was
| patched).  And my GCC/glibc toolchain now builds.  I didn't run the
| glibc testsuite but I ran the GCC testsuite using this patch and
| everything looked fine.

If you want it to work exactly like glibc as a drop in replacement,
you need to copy the NO_ERROR_IN_DST_GAP code from:

    http://nxr.netbsd.org/xref/src/lib/libc/time/localtime.c

christos


More information about the tz mailing list