<br><div class="gmail_quote">On Tue, Feb 2, 2010 at 2:10 PM, Olson, Arthur David (NIH/NCI) [E] <span dir="ltr"><<a href="mailto:olsona@dc37a.nci.nih.gov">olsona@dc37a.nci.nih.gov</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div class="im">> It would be possible to make ctime() be<br>
><br>
> tm = localtime(t);<br>
> if (tm == NULL)<br>
> return NULL;<br>
> return asctime(tm);<br>
><br>
> and in theory that would be adequate, but I'm actually going to suggest moving the fix into asctime() (into asctime_r() really of course), and have<br>
> asctime_r() start<br>
><br>
> if (timeptr == NULL)<br>
> return NULL;<br>
><br>
> I think that's a safer fix. Appended is the patch I suggest, made<br>
> against the tzcode2009t sources (latest I believe.)<br>
<br>
</div>Any sentiment for (or against)...<br>
if (timeptr == NULL)<br>
return "?";<br>
...or...<br>
return "??? ??? ?? ??:??:?? ????\n";<br>
...or some variant?<br>
</blockquote></div><br>AS Robert Elz said, if you are going to use a non-null pointer, then I suggest the 26-character string. As to the contents - I have no problem with question marks followed by a newline; I think the newline at the end is a good idea as people may well rely on its presence to format their information.<br clear="all">
<br>-- <br>Jonathan Leffler <<a href="mailto:jonathan.leffler@gmail.com">jonathan.leffler@gmail.com</a>> #include <disclaimer.h><br>Guardian of DBD::Informix - v2008.0513 - <a href="http://dbi.perl.org">http://dbi.perl.org</a><br>
"Blessed are we who can laugh at ourselves, for we shall never cease to be amused."<br>