<div dir="ltr"><div><div><div><div>Thanks for the correction; I was remembering the bad old days when min_time was a time_t.<br><br></div>So...in the present day, the "dayoff" code is, as you noted, a no-op on systems where longs are 32 bits.<br>
</div>It is still needed on systems where longs are 64 bits. And since "sizeof" can't be used in "#if" directives,<br></div><div>conditionalizing (to get rid of the dead code warning) isn't as easy as we might like.<br>
</div><br></div> @dashdashado<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Mar 5, 2013 at 10:11 PM, Christos Zoulas <span dir="ltr"><<a href="mailto:christos@zoulas.com" target="_blank">christos@zoulas.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On Mar 5, 10:05pm, <a href="mailto:arthurdavidolson@gmail.com">arthurdavidolson@gmail.com</a> (Arthur David Olson) wrote:<br>
-- Subject: Re: [tz] dead code in zic<br>
<br>
</div><div class="im">| While the code in question can surely be improved, it wasn't/isn't a no-op<br>
| on systems where both time_t's and long's were/are 32-bit entities.<br>
<br>
</div>It might not have been when zic_t was a time_t (if it ever was), but it is<br>
a no-op now because zic_t is int_fast64_t. If time_t is 32 or 64 is not<br>
relevant to the particular comparison.<br>
<div class="im"><br>
| The code in question dates back to when "long" was the longest integer type<br>
| available with all compilers ("long long" was not universal then).<br>
<br>
</div>Yes, but things have changed and the code can be made more portable and<br>
work better across a wider set of platforms.<br>
<span class="HOEnZb"><font color="#888888"><br>
christos<br>
</font></span></blockquote></div><br></div>