<div dir="ltr">It looks like "hit" erroneously became a bool in commit "<a href="https://github.com/eggert/tz/commit/7eb7c7349c80e28c531b65d7d196a1bac279aa1c#diff-693adf4be7e59d555ff5f36e00300de7">Use bool for boolean</a>" on Aug 20, 2014. It shouldn't be one. That ++hit is within a loop that would execute should there be a double (or triple ...) leap.<div><div><div><br></div><div>Admittedly, there has never been a double leap, and the powers-that-be would probably change the "end of June/December" rule first should we get close to needing one before leap seconds are abolished altogether, but that doesn't mean we shouldn't simply allow for them.<br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, May 9, 2017 at 8:23 PM, Robert Elz <span dir="ltr"><<a href="mailto:kre@munnari.oz.au" target="_blank">kre@munnari.oz.au</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The following patch was recently added to NetBSD, to appease<br>
GCC 8 (apparently) ... "hit" is a bool, and it seems gcc 8 does<br>
not like ++ operators applied to one of those.<br>
<br>
(deleted parts of the diff which just showed the version ID string<br>
being updated...)<br>
<br>
kre<br>
<br>
Index: src/lib/libc/time/localtime.c<br>
diff -u src/lib/libc/time/localtime.c:<wbr>1.106 src/lib/libc/time/localtime.c:<wbr>1.107<br>
--- src/lib/libc/time/localtime.c:<wbr>1.106 Sat Mar 11 18:23:14 2017<br>
+++ src/lib/libc/time/localtime.c Tue May 9 02:30:49 2017<br>
@@ -1716,7 +1716,7 @@ timesub(const time_t *timep, int_fast32_<br>
sp->lsis[i - 1].ls_trans + 1 &&<br>
sp->lsis[i].ls_corr ==<br>
sp->lsis[i - 1].ls_corr + 1) {<br>
- ++hit;<br>
+ hit = true;<br>
--i;<br>
}<br>
}<br>
<br></blockquote></div></div></div></div></div></div>