fuzz testing tzcode

Paul Eggert eggert at CS.UCLA.EDU
Mon Feb 12 04:04:38 UTC 2007


Curtis Doty <Curtis at GreenKey.net> writes:

> Of course there aren't unmatched quotes in any tzdata files, but
> still... the authors' analysis shouldn't go ignored, no?

Certainly not.  Here's a trivial patch.  Thanks for reporting it.

2006-02-11  Paul Eggert  <eggert at cs.ucla.edu>

	* zic.c (getfields): Catch bug reported in Barton P. Miller,
	Gregory Cooksey, and Fredrick Moore, An empirical study of the
	robustness of MacOS applications using random testing,
	Proc. 1st int. workshop on random testing, Portland, ME (2006)
	<http://doi.acm.org/10.1145/1145735.1145743>.

===================================================================
RCS file: RCS/zic.c,v
retrieving revision 2006.8
retrieving revision 2006.8.0.1
diff -pu -r2006.8 -r2006.8.0.1
--- zic.c	2006/07/20 21:06:31	2006.8
+++ zic.c	2007/02/12 03:41:51	2006.8.0.1
@@ -2451,9 +2451,12 @@ register char *	cp;
 			else while ((*dp = *cp++) != '"')
 				if (*dp != '\0')
 					++dp;
-				else	error(_(
+				else {
+					error(_(
 						"Odd number of quotation marks"
 						));
+					exit(EXIT_FAILURE);
+				}
 		} while (*cp != '\0' && *cp != '#' &&
 			(!isascii(*cp) || !isspace((unsigned char) *cp)));
 		if (isascii(*cp) && isspace((unsigned char) *cp))



More information about the tz mailing list