Two tzcode fixes
mussar at nortel.com
Wed Mar 7 15:47:00 UTC 2007
> -----Original Message-----
> From: Olson, Arthur David (NIH/NCI) [E]
> > diff --git a/timezone/zic.c b/timezone/zic.c index 57dc531..4e3f42f
> > --- a/timezone/zic.c
> > +++ b/timezone/zic.c
> > @@ -650,7 +650,7 @@ const char * const tofile;
> > "../");
> > symlinkcontents =
> > - fromfile);
> > + fromname);
> > result =
> > toname);
> > if (result == 0)
> I don't believe so. "fromname" is the time zone name that
> appears in the
> input files;
> "fromfile" is this name with the name of the directory where output is
> supposed to go prepended.
> Using "fromname" above would yield the moral equivalent of
> "/America/New_York" as a symbolic link, which is not what we want.
It appears that this change was submitted despite Arthur's comment. This impact is that symlinks are created with absolute path names rather than relative path names. This isn't a big deal if the link is being created directly on the target system.
It does impact anyone who attempts to build/install in a non-standard location and then installs the files in the correct location on the target system. This is often the case when cross compiling or when building packages as a non-root userid.
I would prefer to see fromfile used rather than fromname to keep the soft links relative.
More information about the tz