[tz] [PATCH 3/3] tzselect: use /bin/sh by default

Alan Barrett apb at cequrux.com
Sun Oct 28 07:15:57 UTC 2012

On Sat, 27 Oct 2012, Paul Eggert wrote:
>On 10/27/2012 02:06 AM, Mike Frysinger wrote:
>> +	    eval echo \""$b$c) \${$c}"\" >&2
>That looks pretty tricky.

Yes, and there's no reason for $b$c to be expanded twice.  But 
it's easy to make it clearer:

	eval continent=\"\${$c}\"
	echo "$b$c) ${continent}" >&2

> How about if we just default to Bash instead?

If portable /bin/sh is not feasible, then please use the 
intersection of ksh and bash syntax, and make it easy for the 
choice between ksh and bash to be made at install time.  (I have a 
minor preference for ksh over bash, because it's more likely to be 
available on non-linux systems, but if the choice is configurable 
then that's no big deal.)

--apb (Alan Barrett)

More information about the tz mailing list