[tz] [PATCH 00/10] Zone Table Comments

Paul Eggert eggert at cs.ucla.edu
Thu Mar 10 23:28:51 UTC 2016


On 03/09/2016 02:11 PM, J William Piggott wrote:
> Currently tzselect > Africa > Congo (Dem. Rep.) is formatted
> this way. I don't think it is difficult to discern the
> select token.
Ouch, you're right. I didn't notice that:

Please select one of the following time zone regions.
1) +02 - Central Africa Time
2) +01 - West Africa Time
#?

It's confusing that '1' means 2 and '2' means 1 here. Although it's no 
problem for users who know tzselect well, it's likely for other users to 
get confused. So let's drop those confusing prefixes. Something like the 
attached patch, which I've installed in the experimental version.

-------------- next part --------------
From 2b9c19883d00f1a1a2ff2b304ea34989926ba91f Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert at cs.ucla.edu>
Date: Thu, 10 Mar 2016 15:25:57 -0800
Subject: [PATCH] Omit leading numbers from zone*.tab comments
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* zone1970.tab (Africa/Maputo, Africa/Lagos): Omit leading ‘+01’
and ‘+02’ from commentary, so that tzselect doesn’t output
confusing strings like ‘2) +01 - West Africa Time’.
---
 zone1970.tab | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/zone1970.tab b/zone1970.tab
index 657675f..c51f948 100644
--- a/zone1970.tab
+++ b/zone1970.tab
@@ -246,11 +246,11 @@ MX	+3232-11701	America/Tijuana	Pacific Time US - Baja California
 MX	+2048-10515	America/Bahia_Banderas	Central Time - Bahía de Banderas
 MY	+0310+10142	Asia/Kuala_Lumpur	Malaysia (peninsula)
 MY	+0133+11020	Asia/Kuching	Sabah, Sarawak
-MZ,BI,BW,CD,MW,RW,ZM,ZW	-2558+03235	Africa/Maputo	+02 - Central Africa Time
+MZ,BI,BW,CD,MW,RW,ZM,ZW	-2558+03235	Africa/Maputo	Central Africa Time
 NA	-2234+01706	Africa/Windhoek
 NC	-2216+16627	Pacific/Noumea
 NF	-2903+16758	Pacific/Norfolk
-NG,AO,BJ,CD,CF,CG,CM,GA,GQ,NE	+0627+00324	Africa/Lagos	+01 - West Africa Time
+NG,AO,BJ,CD,CF,CG,CM,GA,GQ,NE	+0627+00324	Africa/Lagos	West Africa Time
 NI	+1209-08617	America/Managua
 NL	+5222+00454	Europe/Amsterdam
 NO,SJ	+5955+01045	Europe/Oslo
-- 
2.5.0


More information about the tz mailing list