[tz] [PATCH] Fix warnings if !ALL_STATE: address of gmtmem always, evaluates as true

Andreas Stieger astieger at suse.com
Tue Feb 28 19:34:37 UTC 2017


On 02/28/2017 05:27 PM, Paul Eggert wrote:
> On 02/28/2017 07:59 AM, Andreas Stieger wrote:
>> If ALL_STATE is not defined, the address of gmtcheck always evaluates
>> to true.
> It's valid C code and does the right thing, so this warning is a false
> positive.

It is valid C code and does the right thing, so is the proposal. But
would you not say that less warnings would make the real ones stand out

> Other compilers (and older versions of GCC) may need other options. In
> general the code doesn't bother trying to silence all the warnings
> generated by all the world's C compilers, as the job would be endless
> and we might even have dueling compilers.

Are you aware of any compilers that would object to the patch?


More information about the tz mailing list