[tz] defensive value for define on Solaris causes load of timerule to fail

Kees Dekker Kees.Dekker at infor.com
Tue Jun 13 05:51:14 UTC 2017


>Why not:

>	snprintf(lsp->fullname, sizeof(lsp_fullname), "%s/%s", p, name);

>and remove more code...

Just my 2 cents: looks well, but there are platforms (like MS Window/Visual Studio, see MSDN on snprintf :-() that do not guarantee 
termination of the string if a buffer is too small. To be bulletproof, add lsp->fullname[sizeof(lsp->fullname)-1]='\0';

Kees


More information about the tz mailing list