[tz] zdump bug?
Arthur David Olson
arthurdavidolson at gmail.com
Thu Nov 8 16:41:49 UTC 2018
Re the proposed patch to try to avoid access calls on arguments that
contain just a single dot (changing the code to look for ".."):
There are no filenames with any dots in the zoneinfo tree produced from an
unmodified tz distribution. So whether or not access is called, there will
be one system call for a dot-containing argument; either access or open
will fail and no further calls will be made. Avoiding the access call
doesn't save a system call.
(Looking for ".." rather than "." will save a call on customized systems
that put dot-containing names in the zoneinfo tree.)
On Mon, Oct 29, 2018, 11:47 AM Paul Eggert <eggert at cs.ucla.edu wrote:
> On 10/28/18 9:23 PM, Paul Eggert wrote:
> > 'zdump New_York' is treated differently from 'zdump ./New_York'. It
> > might make sense for the code to try harder to treat only ".."
> > components differently.
> I installed the attached first patch to try to do that. The second
> attached patch silences a warning when running "make
> CFLAGS='$(GCC_DEBUG_FLAGS)' GCC_INSTRUMENT=" on my platform (I updated
> GCC recently).
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the tz