[tz] A small first step in merging NetBSD changes into tzcode

[Robert Elz]

    Date:        Wed, 4 Jan 2023 23:23:20 -0800
    From:        Guy Harris <gharris at sonic.net>
    Message-ID:  <843181AD-42B6-4C06-B0A3-453C1DEC99F3 at sonic.net>

  | The function in question is err(), not perror().

Ah ... that makes a difference, since Paul was talking about building NetBSD
I assumed he was changing the NetBSD sources, rather than tzcode's originals
(which I also see now makes no sense - I should also wake up properly before
replying to e-mail.... not just avoid using my phone).

I'd still recommend the proposed solution though, implement err() for
systems that don't have it, rather than cluttering the code.

  | The change NetBSD made was to replace a call to perror(),

Yes, now I am thinking, that makes sense, for the reasons you say.

  | Or add a non-conditionally-compiled routine similar to err()

That's another possibility, but tzcode already has plenty of conditional
compilation, adding one for this seems easier (it would be exercised both
ways, by major systems, so isn't one of those "bit rot" cases that can occur
when conditionally compiled code is used to allow for things which no-one
does in practice)

kre