[tz] A small first step in merging NetBSD changes into tzcode

Ian Abbott abbotti at mev.co.uk
Thu Jan 5 13:39:36 UTC 2023


On 05/01/2023 13:29, Ian Abbott via tz wrote:
> On 05/01/2023 08:49, Guy Harris via tz wrote:
>> On Jan 4, 2023, at 5:03 PM, Paul Eggert via tz <tz at iana.org> wrote:
>>
>>> I took a look at that and saw there are quite a few changes and 
>>> NetBSD has some gimmicks to deal with old binaries with 32-bit time_t 
>>> (is that still relevant?) so I decided to start with something 
>>> simpler, namely zdump.c. I compared NetBSD zdump.c to tzcode and saw 
>>> one improvement in NetBSD which used a NetBSD-specific function, and 
>>> recoded that in standard POSIX by installing the attached patch into 
>>> tzdb.
>>
>> Is there a reason for doing
>>
>>     char const *e = strerror(errno);
>>     fprintf(stderr, _("%s: setenv: %s\n"), progname, e);
>>
>> rather than
>>
>>     fprintf(stderr, _("%s: setenv: %s\n"), progname, strerror(errno));
> 
> That depends whether _("string") preserves errno or not.

The Linux man page for GNU gettext claims that errno is not modified, 
but the NetBSD man page for Citrus gettext makes no such claim.  Better 
safe than sorry!

-- 
-=( Ian Abbott <abbotti at mev.co.uk> || MEV Ltd. is a company  )=-
-=( registered in England & Wales.  Regd. number: 02862268.  )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-



More information about the tz mailing list