proposed changes to eliminate P macro
jonathan.leffler at gmail.com
Sun Nov 11 18:44:55 UTC 2007
On Nov 9, 2007 9:28 PM, Steven R. Loomis <srl at icu-project.org> wrote:
> On 09 Nov 2007, at 20:51, Jonathan Leffler wrote:
On Nov 8, 2007 6:26 AM, Arthur David Olson <olsona at elsie.nci.nih.gov> wrote:
> Here are proposed changes to eliminate the "P" macro from time zone source
> (a first step in simplifying the code by assuming C99 compilers).
I tried to apply this as a patch and run into two problems.
1. The file names are not readily obvious to the patch program; the
names it sees are /tmp/geta13002 and /tmp/getb13002 etc, rather than (say)
2. There should be a 2 characters (eg two blanks, or "! " or "+ ") at
the start of each line, but by the time Gmail gets the message, there's a
blank missing at the start of lines such as the #ifndef lines at the start
of the patch below. I also had some unfortunate line-wrapping, but I'm
willing to blame that on the (other) email program I use.
3. I tried manually fixing up the patch file for the line starts, but
was not successful.
> ------- date.c -------
> *** /tmp/geta13002 Thu Nov 8 09:23:34 2007
> --- /tmp/getb13002 Thu Nov 8 09:23:34 2007
The patch worked for me, I did "patch < patch.txt" against tzcode2007h and
> fed it each filename in sequence. Compiled fine as well.
> The patch did look a bit strange, as to the filename format.
Thanks. The problem was at my end - working out how to get an uncorrupted
file out of Gmail wasn't as straight-forward as I expected. However, the
third time, I used the "show original" option followed by saving that page
and the patch worked fine when I supplied the names manually.
Steve - thank you for sending the patch to the patch -- I would have used it
except for the problems of getting it out of Gmail, too. By the time I'd
resolved that, I'd also typed the file names in.
Jonathan Leffler <jonathan.leffler at gmail.com> #include <disclaimer.h>
Guardian of DBD::Informix - v2007.0914 - http://dbi.perl.org
"Blessed are we who can laugh at ourselves, for we shall never cease to be
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the tz