[tz] question about mktime_tzname()

Kees Dekker Kees.Dekker at infor.com
Fri Jan 13 13:24:07 UTC 2017

I discovered that zdump.c was updated, and now got additional code from private.h. Why? 

I'm busy porting the code to Windows, and now see duplicate stuff, but private.h is already included in zdump.c. It is not a big problem (but in general, I like to avoid duplicating stuff); I just have to apply some changes that I already applied myself to private.h. In this case: Visual Studio is not setting STDC_VERSION but adheres more or less to STDC (at least, has stdbool.h). When I'm finished I will send a complete patch with my Visual Studio portingset changes (will take some additional time, probably weeks).

Another point of attention is mixing size_t (e.g. result of strlen()) and int. Complaining compilers, especially in 64-bit mode, will raise an warning or error when mixing these types (regarless the tz code will never return a strlen() value that will exceed a signed 32-bit value). I will try to resolve these 64-bit warnings (the Makefile provided with the tzcode still uses a default mode of the compiler. As far as I know, this is 32-bit on most platforms. Changing CFLAGS to -m64 -Wall -Wextra will also show a lot of warnings on e.g. Linux).

-----Original Message-----
From: Kees Dekker 
Sent: Friday, January 13, 2017 09:33
To: 'Paul Eggert' <eggert at cs.ucla.edu>; Arthur David Olson <arthurdavidolson at gmail.com>
Cc: Time Zone Mailing List <tz at iana.org>
Subject: RE: [tz] question about mktime_tzname()

Many thanks. I now used latest source code as retrieved from mentioned git repository. First impression is very good (on RedHat linux, 64-bit). This fix solves a large number of tests (400+) in our own test case. I will do more testing on more platforms. There are still some failing tests in our test suite. I will send a new mail when I have find out the root cause and was able to make a small reproduction. At the final end, I will try to contribute back my changes (Windows related and more). Will be continued. Thanks again.

-----Original Message-----
From: Paul Eggert [mailto:eggert at cs.ucla.edu] 
Sent: Thursday, January 12, 2017 18:48
To: Kees Dekker <Kees.Dekker at infor.com>; Arthur David Olson <arthurdavidolson at gmail.com>
Cc: Time Zone Mailing List <tz at iana.org>
Subject: Re: [tz] question about mktime_tzname()

On 01/12/2017 09:47 AM, Paul Eggert wrote:
> |git <https://git-scm.com> clone https://github.com/eggert/tz |

Sorry, my email client mangled that one. The actual shell command should be:

git clone https://github.com/eggert/tz

More information about the tz mailing list